Here’s the link to the review – http://techchorus.net/zend-framework-18-web-application-development-book-review

My wife wouldn’t “set items into basket” she would “add items to the basket”. Why? Because she wouldn’t remove any previous items of the same kind in basket when adding another

I guess he checks if item is in basket elesewhere (controller?) and if it’s not, he calls this function. But that’s from my point of view wrong ! This logic should be part of model.

Tomas if your wife tells you she went shopping, does she say, she setted an item in her cart, no she probably added it, so why not call the method addItem? And no he doesnt overwrite the item if its already in the basket, just buy the whole book instead of just reading the free chapter and you will see how its done.

public function addItem(Storefront_Resource_Product_Item_Interface $product, $qty)
{
if (0 > $qty) {
return false;
}
if (0 == $qty) {
$this->removeItem($product);
return false;
}
$item = new Storefront_Resource_Cart_Item($product, $qty);
$this->_items[$item->productId] = $item;
$this->persist();
return $item;
}

It’s obvious, that when the item is already in the cart, it’s overwritten. It’s awful. If it’s intended behaviour it should at least be called setItem() as long as it doensn’t “add” but it “sets”.